[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101565#comment-13101565
]
Todd Lipcon commented on HADOOP-1381:
-------------------------------------
Two minor nits:
- Can you add a check in the Writer constructor that the syncInterval option is
valid? I think the minimum value would be SYNC_SIZE?
- Can you rename SYNC_INTERVAL to DEFAULT_SYNC_INTERVAL or
SYNC_INTERVAL_DEFAULT? Even though it's currently public, I don't think this
would be considered a public API, so changing it seems alright.
Otherwise looks good.
> The distance between sync blocks in SequenceFiles should be configurable
> rather than hard coded to 2000 bytes
> -------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-1381
> URL: https://issues.apache.org/jira/browse/HADOOP-1381
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.22.0
> Reporter: Owen O'Malley
> Assignee: Harsh J
> Fix For: 0.23.0
>
> Attachments: HADOOP-1381.r1.diff, HADOOP-1381.r2.diff,
> HADOOP-1381.r3.diff, HADOOP-1381.r4.diff
>
>
> Currently SequenceFiles put in sync blocks every 2000 bytes. It would be much
> better if it was configurable with a much higher default (1mb or so?).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
