steveloughran commented on a change in pull request #1872: Hadoop 16890: Change
in expiry calculation for MSI token provider
URL: https://github.com/apache/hadoop/pull/1872#discussion_r390958751
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/AzureADAuthenticator.java
##########
@@ -258,8 +258,13 @@ public UnexpectedResponseException(final int
httpErrorCode,
}
private static AzureADToken getTokenCall(String authEndpoint, String body,
- Hashtable<String, String> headers,
String httpMethod)
- throws IOException {
+ Hashtable<String, String> headers, String httpMethod) throws IOException
{
+ return getTokenCall(authEndpoint, body, headers, httpMethod, false);
+ }
+
+ private static AzureADToken getTokenCall(String authEndpoint, String body,
+ Hashtable<String, String> headers, String httpMethod, boolean isMsi)
Review comment:
Not something needing changing in this PR, but this should really be Map<>
and the code to move to a HashMap; all of Hashtable's methods are synchronized
and it underperforms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
