steveloughran commented on a change in pull request #1899: HADOOP-16914 Adding
Output Stream Counters in ABFS
URL: https://github.com/apache/hadoop/pull/1899#discussion_r395745249
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStreamStatistics.java
##########
@@ -0,0 +1,60 @@
+package org.apache.hadoop.fs.azurebfs.services;
+
+import org.apache.hadoop.classification.InterfaceStability;
+
+/**
+ * Interface for {@link AbfsOutputStream} statistics.
+ */
[email protected]
+public interface AbfsOutputStreamStatistics {
+
+ /**
+ * Number of bytes to be uploaded.
+ *
+ * @param bytes number of bytes to upload
+ */
+ void bytesToUpload(long bytes);
+
+ /**
+ * Number of bytes uploaded Successfully.
+ *
+ * @param bytes number of bytes that were successfully uploaded
+ */
+ void bytesUploadedSuccessfully(long bytes);
+
+ /**
+ * Number of bytes failed to upload.
+ *
+ * @param bytes number of bytes that failed to upload
+ */
+ void bytesFailed(long bytes);
Review comment:
prefer a more detailed description like uploadFailed(long). It's recording
that an upload failed and the number of bytes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
