[
https://issues.apache.org/jira/browse/HADOOP-16912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063539#comment-17063539
]
Chao Sun commented on HADOOP-16912:
-----------------------------------
Thanks [~fengnanli] for the update! Looks pretty good to me with a few comments
(mostly nits):
1. In {{DecayRpcSchedulerDetailedMetrics}}, can we change
{{rpcschedulerdetailed}} in {{context}} to {{decayrpcschedulerdetailed}} as
well?
2. In {{DecayRpcSchedulerDetailedMetrics}}, the variable {{LOG}} can be
private, and methods {{getRpcQueueRates}} and {{getRpcProcessingRates}} can be
package-private.
3. Please add a blank line between method description and the first line with
{{@param}}.
4. Perhaps the test on {{MutableRatesWithAggregation#init}} can be added to
{{TestMutableMetrics}}? this also removes the necessity of changing
{{getGlobalMetrics}} to public.
5. We'll also need to document this in {{Metrics.md}} for the newly added
metrics.
> Emit per priority rpc queue time and processing time from DecayRpcScheduler
> ---------------------------------------------------------------------------
>
> Key: HADOOP-16912
> URL: https://issues.apache.org/jira/browse/HADOOP-16912
> Project: Hadoop Common
> Issue Type: New Feature
> Components: common
> Reporter: Fengnan Li
> Assignee: Fengnan Li
> Priority: Major
> Labels: metrics
> Attachments: HADOOP-16912.001.patch, HADOOP-16912.002.patch,
> HADOOP-16912.003.patch, HADOOP-16912.004.patch, HADOOP-16912.005.patch
>
>
> At ipc Server level we have the overall rpc queue time and processing time
> for the whole CallQueueManager. In the case of using FairCallQueue, it will
> be great to know the per queue/priority level rpc queue time since many times
> we want to keep certain queues to meet some queue time SLA for customers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
