goiri commented on a change in pull request #1915: YARN-10210. Add a RMFailoverProxyProvider that does DNS resolution on failover URL: https://github.com/apache/hadoop/pull/1915#discussion_r398212727
########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailoverProxyProvider.java ########## @@ -0,0 +1,306 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.client; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.io.retry.FailoverProxyProvider; +import org.apache.hadoop.yarn.api.ApplicationClientProtocol; +import org.apache.hadoop.yarn.conf.YarnConfiguration; +import org.apache.hadoop.yarn.exceptions.YarnException; +import org.junit.Before; +import org.junit.Test; + +import java.io.Closeable; +import java.io.IOException; +import java.lang.reflect.InvocationHandler; +import java.lang.reflect.Proxy; +import java.net.InetSocketAddress; + +import static org.junit.Assert.*; +import static org.mockito.Mockito.any; +import static org.mockito.Mockito.eq; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +/** + * Unit tests for {@link ConfiguredRMFailoverProxyProvider} and + * {@link AutoRefreshRMFailoverProxyProvider}. + */ +public class TestRMFailoverProxyProvider { + + // Default port of yarn RM + private static final int RM1_PORT = 8032; + private static final int RM2_PORT = 8031; + private static final int RM3_PORT = 8033; + + private Configuration conf; + + @Before + public void setUp() throws IOException, YarnException { + conf = new YarnConfiguration(); + conf.setClass(YarnConfiguration.CLIENT_FAILOVER_NO_HA_PROXY_PROVIDER, + ConfiguredRMFailoverProxyProvider.class, RMFailoverProxyProvider.class); + conf.setBoolean(YarnConfiguration.RM_HA_ENABLED, true); + } + + /** + * Test that the {@link ConfiguredRMFailoverProxyProvider} + * will loop through its set of proxies when + * and {@link ConfiguredRMFailoverProxyProvider#performFailover(Object)} + * gets called. + */ + @Test + public void testFailoverChange() throws Exception { + //Adjusting the YARN Conf + conf.set(YarnConfiguration.RM_HA_IDS, "rm0, rm1"); + + // Create two proxies and mock a RMProxy + Proxy mockProxy2 = new TestProxy((proxy, method, args) -> null); Review comment: Yetus complains here: error: Proxy(InvocationHandler) has protected ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
