steveloughran commented on issue #1924: HADOOP-16877. S3A FS deleteOnExit to skip the exists check. URL: https://github.com/apache/hadoop/pull/1924#issuecomment-606507397 And of course I didn't read the javadocs in FileSystem I added last month so should have expected the stack traces. [INFO] [ERROR] Failures: [ERROR] TestFileSystemCaching.testCancelDeleteOnExit:313 [ERROR] TestFileSystemCaching.testDeleteOnExit:259 [ERROR] TestFileSystemCaching.testDeleteOnExitFNF:278 Argument(s) are different! Wanted: fileSystem.getFileStatus(/a); -> at org.apache.hadoop.fs.TestFileSystemCaching.testDeleteOnExitFNF(TestFileSystemCaching.java:278) Actual invocations have different arguments: fileSystem.makeQualified(/a); -> at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:124) fileSystem.getFileStatus(null); -> at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:460) [ERROR] TestFileSystemCaching.testDeleteOnExitRemoved:296 [ERROR] TestFilterFileSystem.testFilterFileSystem:170 1 methods were not overridden correctly - see log [ERROR] TestHarFileSystem.testInheritedMethodsImplemented:393 1 methods were not overridden correctly - see log [ERROR] Errors: [ERROR] TestChRootedFileSystem.testDeleteOnExitPathHandling:346 ? NullPointer [INFO] [ERROR] Tests run: 4401, Failures: 6, Errors: 1, Skipped: 255 [INFO] Hmm. I think I might just rewind all changes to FileSystem and have S3A build up its own list of files to delete and then delete them at teardown. Avoids complexity and would let us go to submitting delete operations to the thread pool
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
