steveloughran commented on a change in pull request #1925: HADOOP-16948. Support single writer dirs. URL: https://github.com/apache/hadoop/pull/1925#discussion_r401582621
########## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ########## @@ -328,13 +406,16 @@ public AbfsRestOperation renamePath(String source, final String destination, fin } public AbfsRestOperation append(final String path, final long position, final byte[] buffer, final int offset, - final int length, boolean flush, boolean isClose) + final int length, boolean flush, boolean isClose, final String leaseId) Review comment: this seems to be recurrent merge pain point: too many patches adding more things to every rest call. Proposed: how about adding a RestOperationContext struct which gets passed down, leaseId would go in there, and later other stuff (statistics, trace context, etc) ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
