steveloughran commented on a change in pull request #1946: HADOOP-16961. ABFS: Adding metrics to AbfsInputStream URL: https://github.com/apache/hadoop/pull/1946#discussion_r405635427
########## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java ########## @@ -41,6 +43,12 @@ public class AbfsInputStream extends FSInputStream implements CanUnbuffer, StreamCapabilities { + private static final Logger LOG = LoggerFactory.getLogger( + AbfsInputStream.class); + + /** Stream statistics. */ + private final AbfsInputStreamStatisticsImpl streamStatistics; Review comment: interface rather than impl? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org