brfrn169 commented on a change in pull request #1954: HDFS-15217 Add more
information to longest write/read lock held log
URL: https://github.com/apache/hadoop/pull/1954#discussion_r407141488
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystemLock.java
##########
@@ -106,8 +107,8 @@ public Long initialValue() {
* lock was held since the last report.
*/
private final AtomicReference<LockHeldInfo> longestReadLockHeldInfo =
- new AtomicReference<>(new LockHeldInfo(0, 0, null));
- private LockHeldInfo longestWriteLockHeldInfo = new LockHeldInfo(0, 0, null);
+ new AtomicReference<>(new LockHeldInfo(0, 0, null, null, null));
+ private LockHeldInfo longestWriteLockHeldInfo = new LockHeldInfo(0, 0, null,
null, null);
Review comment:
Maybe it's better to have default constructor (without any parameters) of
LockHeldInfo for those initial instances? I will try to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
