[ https://issues.apache.org/jira/browse/HADOOP-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103886#comment-13103886 ]
Jitendra Nath Pandey commented on HADOOP-7602: ---------------------------------------------- Comparing the latest patch with the earliest patch that John had, I am more inclined towards the earlier approach. The point is that the methods buildDTService and buildDTAuthority in SecurityUtil are public utility methods but are not handling the invalid input well. In some cases they do return empty string host, but not consistently. I think better approach is to make that behavior consistent. In most common case when these methods are called with an invalid input, the caller code doesn't really care about what they return. For example, calling buildDTService for har file system. > wordcount, sort etc on har files fails with NPE > ----------------------------------------------- > > Key: HADOOP-7602 > URL: https://issues.apache.org/jira/browse/HADOOP-7602 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 0.20.205.0, 0.20.206.0 > Reporter: John George > Assignee: John George > Fix For: 0.20.205.0 > > Attachments: hadoop-7602.1.patch, hadoop-7602.2.patch, > hadoop-7602.3.patch, hadoop-7602.4.patch, hadoop-7602.daryns_comment.2.patch, > hadoop-7602.daryns_comment.patch, hadoop-7602.patch > > > wordcount, sort etc on har files fails with > NPE@createSocketAddr(NetUtils.java:137). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira