bilaharith commented on a change in pull request #1937: HADOOP-16937. ABFS:
revert combined append+flush calls., with default config to disable
append+flush calls.
URL: https://github.com/apache/hadoop/pull/1937#discussion_r408370742
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -283,17 +289,16 @@ public synchronized void close() throws IOException {
private synchronized void flushInternal(boolean isClose) throws IOException {
maybeThrowLastError();
- writeCurrentBufferToService();
- flushWrittenBytesToService(isClose);
+ writeAndFlushWrittenBytesToService(isClose);
}
private synchronized void flushInternalAsync() throws IOException {
maybeThrowLastError();
- writeCurrentBufferToService();
+ writeCurrentBufferToService(true, false);
flushWrittenBytesToServiceAsync();
}
- private synchronized void writeCurrentBufferToService() throws IOException {
+ private synchronized void writeCurrentBufferToService(final boolean flush,
final boolean isClose) throws IOException {
Review comment:
rename to isFlush
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
