mehakmeet commented on a change in pull request #1899: HADOOP-16914 Adding
Output Stream Counters in ABFS
URL: https://github.com/apache/hadoop/pull/1899#discussion_r408492995
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -436,4 +453,28 @@ private void waitForTaskToComplete() throws IOException {
public synchronized void waitForPendingUploads() throws IOException {
waitForTaskToComplete();
}
+
+ /**
+ * Getter method for AbfsOutputStream Statistics.
+ *
+ * @return statistics for AbfsOutputStream.
+ */
+ @VisibleForTesting
+ public AbfsOutputStreamStatisticsImpl getOutputStreamStatistics() {
Review comment:
I think it expects to return AbfsOutputStreamStatisticsImpl, and if we
return just AbfsOutputStreamStatistics, it would give rise to incompatible
types error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
