steveloughran commented on issue #1948: HADOOP-16986. s3a to not need wildfly 
on the classpath
URL: https://github.com/apache/hadoop/pull/1948#issuecomment-613920202
 
 
   * checkstyle on length of comments and debug logs; fixed.
   * fixed site issues, also did another review of the openssl section
   
   not done a test rerun except the new test suite from the IDE, one where I 
haven't yet done a mvn import to pick up the changes in classpaths of s3a.
   
   Notable that on the mac openssl does seem to be found in this situation.
   
   ```
   
   org.junit.ComparisonFailure: [Channel mode of socket factory created with 
mode Default] 
   Expected :Default_JSSE
   Actual   :OpenSSL
   <Click to see difference>
   
   
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at 
org.apache.hadoop.fs.s3a.TestOpenSSLClasspaths.expectBound(TestOpenSSLClasspaths.java:111)
        at 
org.apache.hadoop.fs.s3a.TestOpenSSLClasspaths.testDefaultDowngrades(TestOpenSSLClasspaths.java:88)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
        at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to