brfrn169 commented on a change in pull request #1954: HDFS-15217 Add more
information to longest write/read lock held log
URL: https://github.com/apache/hadoop/pull/1954#discussion_r409103492
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
##########
@@ -3204,11 +3235,12 @@ void renameTo(final String src, final String dst,
res = FSDirRenameOp.renameToInt(dir, pc, src, dst, logRetryCache,
options);
} finally {
- writeUnlock(operationName);
+ FileStatus status = res != null ? res.auditStat : null;
+ writeUnlock(operationName,
+ getLockReportInfoSupplier(src, dst, status));
}
} catch (AccessControlException e) {
- logAuditEvent(false, operationName + " (options=" +
- Arrays.toString(options) + ")", src, dst, null);
+ logAuditEvent(false, operationName, src, dst, null);
Review comment:
Thank you for pointing out this. I modified the patch for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
