mukund-thakur commented on a change in pull request #1955: HADOOP-13873 log DNS
addresses on s3a init
URL: https://github.com/apache/hadoop/pull/1955#discussion_r409385022
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -503,6 +501,15 @@ private void doBucketProbing() throws IOException {
}
}
+ private void logDnsLookup() {
+ String endPoint = getConf().getTrimmed(ENDPOINT, "");
Review comment:
> * make the default "s3.amazonaws.com" so we fall back to that?
Yes we can fall back as s3 client uses this by default if endpoint is not
set explicitly.
> * AWS docs imply that this can be a full https:// URL; never tested that
to see what happens in our own code, but we may want to handle it here.
For this we have to trim the prefix. Also what if a port is present in the
endpoint like https://<host>:port. Should I trim the port as well?
There is no method to do this out of box in NetUtils but I can do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
