[ 
https://issues.apache.org/jira/browse/HADOOP-16963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088480#comment-17088480
 ] 

Steve Loughran commented on HADOOP-16963:
-----------------------------------------

What HADOOP-16582 does is guarantee that filtering/viewing filesystems pass 
mkdirs(path) all the way through; the standard FileSystem.mkdirs(path) does the 
expansion. 

How/why does hive break here? 

is the problem that hive has a filterFS which overrides FilterFS.mkdir(path, 
perm) but not FilterFS.mkdir(path)? If so, I think
-hive needs to add the mkdirs(path) call. This can be done and still compile 
against older hadoop versions
-we tag the previous patch as an incompatible for filesystem extending FilterFS.



> HADOOP-16582 changed mkdirs() behavior
> --------------------------------------
>
>                 Key: HADOOP-16963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16963
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.10.0, 3.3.0, 2.8.6, 2.9.3, 3.1.3, 3.2.2
>            Reporter: Wei-Chiu Chuang
>            Priority: Critical
>
> HADOOP-16582 changed behavior of {{mkdirs()}}
> Some Hive tests depend on the old behavior and they fail miserably.
> {quote}
> earlier:
> all plain mkdirs(somePath) were fast-tracked to FileSystem.mkdirs which have 
> rerouted them to mkdirs(somePath, somePerm) method with some defaults (which 
> were static)
> an implementation of FileSystem have only needed implement "mkdirs(somePath, 
> somePerm)" - because the other was not neccessarily called if it was always 
> in a FilterFileSystem or something like that
> now:
> especially FilterFileSystem forwards the call of mkdirs(p) to the actual fs 
> implementation...which may skip overriden mkdirs(somPath,somePerm) methods
> ...and could cause issues for existing FileSystem implementations
> {quote}
> File this jira to address this problem.
> [~kgyrtkirk] [[email protected]] [~kihwal]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to