snvijaya commented on a change in pull request #1923:
URL: https://github.com/apache/hadoop/pull/1923#discussion_r412520627
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/CustomTokenProviderAdapter.java
##########
@@ -46,16 +48,53 @@
*
* @param adaptee the custom token provider
*/
- public CustomTokenProviderAdapter(CustomTokenProviderAdaptee adaptee) {
+ public CustomTokenProviderAdapter(CustomTokenProviderAdaptee adaptee, int
customTokenFetchRetryCount) {
Preconditions.checkNotNull(adaptee, "adaptee");
this.adaptee = adaptee;
+ fetchTokenRetryCount = customTokenFetchRetryCount;
}
protected AzureADToken refreshToken() throws IOException {
LOG.debug("AADToken: refreshing custom based token");
AzureADToken azureADToken = new AzureADToken();
- azureADToken.setAccessToken(adaptee.getAccessToken());
+
+ String accessToken = null;
+
+ Exception ex;
+ boolean succeeded = false;
+ // Custom token providers should have their own retry policies,
+ // Providing a linear retry option for the the retry count
+ // mentioned in config "fs.azure.custom.token.fetch.retry.count"
+ int retryCount = fetchTokenRetryCount;
+ do {
+ ex = null;
+ try {
+ accessToken = adaptee.getAccessToken();
+ LOG.trace("CustomTokenProvider Access token fetch was successful with
retry count {}", retryCount);
+ } catch (Exception e) {
Review comment:
I checked across few articles and recommendation seems to be to not
catch throwable. At this point we need to catch any exception coming from the
CustomTokenProvider.
Pasting couple of links I referenced:
- https://stackify.com/best-practices-exceptions-java/ => scroll to "6.
Don’t Catch Throwable"
-
https://www.baeldung.com/java-catch-throwable-bad-practice#catching-throwable
Please let me know if you still think this needs to be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
