DadanielZ commented on a change in pull request #1969:
URL: https://github.com/apache/hadoop/pull/1969#discussion_r412655425
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java
##########
@@ -732,6 +740,11 @@ void setListMaxResults(int listMaxResults) {
this.listMaxResults = listMaxResults;
}
+ @VisibleForTesting
+ void setIsNamespaceEnabledAccount(String isNamespaceEnabledAccount) {
+ this.isNamespaceEnabledAccount = isNamespaceEnabledAccount;
Review comment:
the method signature should be simpler, it is better to declare it as
`boolean` and do the string conversion inside this method, or declare the
`isNamespaceEnabledAccount` as `Enum` to differentiate between `NOT_SET, TRUE
and FALSE.`
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -255,6 +260,20 @@ public boolean getIsNamespaceEnabled() throws
AzureBlobFileSystemException {
return isNamespaceEnabled;
}
+ @VisibleForTesting
+ boolean isNameSpaceEnabledSetFromConfig() {
+ final String hnsEnabledConfig = abfsConfiguration
+ .getIsNamespaceEnabledAccount();
Review comment:
is line break needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
