mukund-thakur commented on a change in pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#discussion_r413027323
########## File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/statistics/TestEmptyIOStatistics.java ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.statistics; + +import java.util.Iterator; +import java.util.Map; + +import org.junit.Test; + +import org.apache.hadoop.fs.statistics.impl.EmptyIOStatistics; +import org.apache.hadoop.test.AbstractHadoopTestBase; + +import static org.apache.hadoop.fs.statistics.IOStatisticAssertions.assertDoesNotHaveAttribute; +import static org.apache.hadoop.fs.statistics.IOStatisticAssertions.assertHasAttribute; +import static org.apache.hadoop.fs.statistics.IOStatisticAssertions.assertStatisticTracked; +import static org.apache.hadoop.fs.statistics.IOStatisticAssertions.assertStatisticUnknown; +import static org.apache.hadoop.fs.statistics.IOStatisticAssertions.assertStatisticUntracked; +import static org.apache.hadoop.fs.statistics.IOStatisticAssertions.assertStatisticHasValue; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +/** + * Test handling of the empty IO statistics class. + */ +public class TestEmptyIOStatistics extends AbstractHadoopTestBase { + + private final IOStatistics stats = EmptyIOStatistics.getInstance(); + + @Test + public void testAttributes() throws Throwable { + assertHasAttribute(stats, IOStatistics.Attributes.Static); + assertDoesNotHaveAttribute(stats, IOStatistics.Attributes.Dynamic); + assertDoesNotHaveAttribute(stats, IOStatistics.Attributes.Snapshotted); + } + + @Test + public void testSnapshotUnsupported() throws Throwable { + assertThat(stats.snapshot()) + .describedAs("Snapshot of %s", stats) + .isFalse(); + } + + @Test + public void testIterator() throws Throwable { + Iterator<Map.Entry<String, Long>> iterator = stats.iterator(); + + assertThat(iterator.hasNext()) + .describedAs("iterator.hasNext()") + .isFalse(); + assertThatThrownBy(iterator::next); + } + + @Test + public void testUnknownStatistic() throws Throwable { + assertStatisticUnknown(stats, "anything"); + assertStatisticUntracked(stats, "anything"); + + // These actually test the assertion coverage + assertThatThrownBy(() -> Review comment: Do you mind explaining a bit more for this. Thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
