[ https://issues.apache.org/jira/browse/HADOOP-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089997#comment-17089997 ]
Hudson commented on HADOOP-17001: --------------------------------- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18173 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/18173/]) HADOOP-17001. The suffix name of the unified compression class. (liuml07: rev af85971a5842e47cf94b6e48de3091a8723b0eb3) * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/PassthroughCodec.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/BZip2Codec.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/GzipCodec.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/DefaultCodec.java * (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CodecConstants.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/Lz4Codec.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/ZStandardCodec.java > The suffix name of the unified compression class > ------------------------------------------------ > > Key: HADOOP-17001 > URL: https://issues.apache.org/jira/browse/HADOOP-17001 > Project: Hadoop Common > Issue Type: Improvement > Components: io > Affects Versions: 3.2.1 > Reporter: bianqi > Assignee: bianqi > Priority: Major > Attachments: HADOOP-17001.003.patch, HADOOP-17001.004.patch, > HADOOP-17001.005.patch > > > The suffix name of the unified compression class,I think the suffix name in > the compression class should be extracted into a constant class, which is > helpful for developers to understand the structure of the compression class > as a whole. > {quote}public static final String OPT_EXTENSION = > "io.compress.passthrough.extension"; > /** > * This default extension is here so that if no extension has been defined, > * some value is still returned: \{@value}.. > */ > public static final String DEFAULT_EXTENSION = ".passthrough"; > private Configuration conf; > private String extension = DEFAULT_EXTENSION; > public PassthroughCodec() { > } > {quote} > The above code, the use of constants is a bit messy. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org