[
https://issues.apache.org/jira/browse/HADOOP-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HADOOP-17001:
-----------------------------------
Fix Version/s: 3.4.0
3.2.2
3.1.4
3.3.0
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
+1
Failures are not related and I can build locally without problems. We don't
need tests for this since there is no logic changes in patch.
Committed to {{trunk}}, {{branch-3.3}}, {{branch-3.2}}, {{branch-3.1}}
branches. Thanks for your contribution, [~bianqi]. Thanks for reviewing
[~weichiu]
[~brahmareddy] Is this commit in {{branch-3.3}} for 3.3.0 or 3.3.1? I'm not
sure if you have cut branch-3.3.0 for releasing. Let me know. Thanks!
> The suffix name of the unified compression class
> ------------------------------------------------
>
> Key: HADOOP-17001
> URL: https://issues.apache.org/jira/browse/HADOOP-17001
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.2.1
> Reporter: bianqi
> Assignee: bianqi
> Priority: Major
> Fix For: 3.3.0, 3.1.4, 3.2.2, 3.4.0
>
> Attachments: HADOOP-17001.003.patch, HADOOP-17001.004.patch,
> HADOOP-17001.005.patch
>
>
> The suffix name of the unified compression class,I think the suffix name in
> the compression class should be extracted into a constant class, which is
> helpful for developers to understand the structure of the compression class
> as a whole.
> {quote}public static final String OPT_EXTENSION =
> "io.compress.passthrough.extension";
> /**
> * This default extension is here so that if no extension has been defined,
> * some value is still returned: \{@value}..
> */
> public static final String DEFAULT_EXTENSION = ".passthrough";
> private Configuration conf;
> private String extension = DEFAULT_EXTENSION;
> public PassthroughCodec() {
> }
> {quote}
> The above code, the use of constants is a bit messy.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
