[
https://issues.apache.org/jira/browse/HADOOP-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105016#comment-13105016
]
Jitendra Nath Pandey commented on HADOOP-7602:
----------------------------------------------
+1 for the current patch.
Some usage might be calling getCanonicalService and assuming non null value in
return. But as it is, this method is not returning anything useful for
HARFileSystem. Therefore it is not a big risk to return null for this method.
Summary of a discussion with Nathan:
SecurityUtil APIs should be fixed. Throwing a checked exception might cause
backward compatibility issues and returning an empty string may have an issue
that some user code may be parsing the service assuming it is ip:port. Although
the API doesn't gaurantee a specific service format but in hadoop it has been
assumed to be "ip:port"
So we have two options:
1) A very conservative option to return ":0", which is the current behavior
in certain cases of invalid input.
2) Throw IllegalArgumentException which is better than NPE and is
semantically clearer.
> wordcount, sort etc on har files fails with NPE
> -----------------------------------------------
>
> Key: HADOOP-7602
> URL: https://issues.apache.org/jira/browse/HADOOP-7602
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.205.0, 0.20.206.0
> Reporter: John George
> Assignee: John George
> Fix For: 0.20.205.0
>
> Attachments: hadoop-7602.1.patch, hadoop-7602.2.patch,
> hadoop-7602.3.patch, hadoop-7602.4.patch, hadoop-7602.6.patch,
> hadoop-7602.7.patch, hadoop-7602.8.patch, hadoop-7602.9.patch,
> hadoop-7602.daryns_comment.2.patch, hadoop-7602.daryns_comment.patch,
> hadoop-7602.patch
>
>
> wordcount, sort etc on har files fails with
> NPE@createSocketAddr(NetUtils.java:137).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
