mukund-thakur commented on pull request #1944: URL: https://github.com/apache/hadoop/pull/1944#issuecomment-620450785
I think it is kind of impossible to write integration test for this as we have 5 MB minimum block size check at multiple places. Even if we remove those checks, we will have to do 10000 POST calls which will make the test super slow. Also, I tried removing the 5 MB checks but the test fails with StackOverflow error because of the tail recursion present at https://github.com/apache/hadoop/blob/5e0eda5d5f696aba7fc209874d232baf2a50d547/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ABlockOutputStream.java#L296 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
