steveloughran commented on a change in pull request #1950:
URL: https://github.com/apache/hadoop/pull/1950#discussion_r418483936
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardToolLocal.java
##########
@@ -165,18 +165,19 @@ public void testImportNoFilesystem() throws Throwable {
@Test
public void testInfoBucketAndRegionNoFS() throws Throwable {
- intercept(FileNotFoundException.class,
+ intercept(UnknownStoreException.class,
Review comment:
we should probably unset bucket probe options too & switch to the
default (2) value; avoid differences in init behaviour
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardToolLocal.java
##########
@@ -57,13 +59,18 @@
private static final String[] ABORT_FORCE_OPTIONS = new String[] {"-abort",
"-force", "-verbose"};
+ @Override
+ protected Configuration createConfiguration() {
+ Configuration conf = super.createConfiguration();
+ conf.set(S3_METADATA_STORE_IMPL, S3GUARD_METASTORE_LOCAL);
Review comment:
need to use the `removeBaseAndBucketOverrides()` code in S3ATestUtils to
make sure that any per-bucket setting has turned it on. Look for other uses to
see what to do
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardToolLocal.java
##########
@@ -97,7 +98,6 @@ public void testImportCommand() throws Exception {
.getListing().size());
assertEquals("Expected 2 items: empty directory and a parent directory", 2,
ms.listChildren(parent).getListing().size());
- assertTrue(children.isAuthoritative());
Review comment:
probably is wrong then :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
