snvijaya commented on a change in pull request #2021:
URL: https://github.com/apache/hadoop/pull/2021#discussion_r425625914
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java
##########
@@ -321,9 +324,81 @@ public AbfsRestOperation renamePath(String source, final
String destination, fin
url,
requestHeaders);
op.execute();
+
+ if (op.getResult().getStatusCode() != HttpURLConnection.HTTP_OK) {
+ return renameIdempotencyCheckOp(op, destination);
+ }
+
return op;
}
+ /**
Review comment:
AbfsClient class handles triggering of requests to Store backend and
returning the AbfsRestOperation back. For Rename and Delete, the response to
return is not determined if request was re-tried by the idempotent logic. It
will be not right to consider these methods as "assisting" or providing a
utility service and are part of the actual flow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
