jojochuang commented on a change in pull request #2016:
URL: https://github.com/apache/hadoop/pull/2016#discussion_r425955353
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/client/impl/TestBlockReaderLocal.java
##########
@@ -130,10 +130,14 @@ public void doTest(BlockReaderLocal reader, byte
original[])
throws IOException {
// default: no-op
}
- }
+ public void doTest(BlockReaderLocal reader, byte[] original, int shift)
+ throws IOException {
+ // default: no-op
+ } }
public void runBlockReaderLocalTest(BlockReaderLocalTest test,
- boolean checksum, long readahead) throws IOException {
+ boolean checksum, long readahead, int shortCircuitCachesNum)
Review comment:
A lot of test code changes are not needed if you add an overriding
method runBlockReaderLocalTest(BlockReaderLocalTest test, boolean checksum,
long readahead) that calls runBlockReaderLocalTest(test, checksum, readahead,
1);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
