umamaheswararao commented on pull request #2061:
URL: https://github.com/apache/hadoop/pull/2061#issuecomment-640305449
Thanks @ayushtkn for spending time on this.
I think these assertions might have derived from HDFS symlink design, where
HDFS symlink will not be an InodeDirectory. Instead is will be always
`public class INodeSymlink extends INodeWithAdditionalFields {`
This will return isDir as always false. That tells, both symlink and isDir
cannot be true in HDFS perspective. But as in ViewFS case, its not limited to
HDFS. I think its good to support in similar to how other fs supporting. But I
am not very sure where that assert checks are going to impact (ex: if
downstream projects enable assertion on their runs).
CC: @jojochuang @rakeshadr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
