steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-642142997
aah, i need to rebase. @mehakmeet -this is going to complicate your life. sorry. I'll do a whole new PR. having written the new extensible design, I've decided I don't like it. It is too complex as I'm trying to support arbitrary arity tuples of any kind of statistic.it makes iterating/parsing this stuff way too complext here's a better idea: we only support a limited set; * counter: long * min; long * max: long * mean (double, long) * gauge; long 1. all but gauge have simple aggregation, for gauge i'll add stuff up too, on the assumption that they will be positive values (e.g 'number of active reads') 1. and every set will have its own iterator. what do people think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
