aajisaka commented on a change in pull request #2075:
URL: https://github.com/apache/hadoop/pull/2075#discussion_r440661218
##########
File path: hadoop-client-modules/hadoop-client-runtime/pom.xml
##########
@@ -158,11 +158,8 @@
<!-- the jdk ships part of the javax.annotation
namespace, so if we want to relocate this we'll have to care it out by class :(
-->
<exclude>com.google.code.findbugs:jsr305</exclude>
<exclude>io.dropwizard.metrics:metrics-core</exclude>
- <exclude>org.eclipse.jetty.websocket:*</exclude>
<exclude>org.eclipse.jetty:jetty-servlet</exclude>
<exclude>org.eclipse.jetty:jetty-security</exclude>
- <exclude>org.eclipse.jetty:jetty-client</exclude>
- <exclude>org.eclipse.jetty:jetty-http</exclude>
<exclude>org.eclipse.jetty:jetty-xml</exclude>
Review comment:
Agreed that jetty-client and jetty-http are shaded as well because jetty
websocket-client depends on them.
websocket-client depends on jetty-xml, too. Should we shade jetty-xml or
not?
https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-websocket/websocket-client/pom.xml#L25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
