sunchao commented on a change in pull request #2080:
URL: https://github.com/apache/hadoop/pull/2080#discussion_r443079600
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterWebHdfsMethods.java
##########
@@ -454,19 +454,12 @@ private URI redirectURI(final Router router, final
UserGroupInformation ugi,
private DatanodeInfo chooseDatanode(final Router router,
final String path, final HttpOpParam.Op op, final long openOffset,
final String excludeDatanodes) throws IOException {
- // We need to get the DNs as a privileged user
final RouterRpcServer rpcServer = getRPCServer(router);
- UserGroupInformation loginUser = UserGroupInformation.getLoginUser();
- RouterRpcServer.setCurrentUser(loginUser);
-
DatanodeInfo[] dns = null;
try {
- dns = rpcServer.getDatanodeReport(DatanodeReportType.LIVE);
+ dns = rpcServer.getCachedDatanodeReport(DatanodeReportType.LIVE);
Review comment:
Question from me and not quite related to this JIRA: seems this is
getting DNs for all the clusters while in the `CREATE` case we should only
choose DN from a particular sub-cluster. Where is this logic implemented?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
##########
@@ -18,6 +18,8 @@
package org.apache.hadoop.hdfs.server.federation.router;
import static
org.apache.hadoop.fs.CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION;
+import static
org.apache.hadoop.hdfs.server.federation.metrics.NamenodeBeanMetrics.DN_REPORT_CACHE_EXPIRE;
Review comment:
This will cause compilation error. Also I'm wondering whether it makes
sense to move the DN cache logic from `NamenodeBeanMetrics` to here and have
the former to depend on this. This way we don't have to keep two copies of
cache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
