Hexiaoqiao commented on pull request #2047: URL: https://github.com/apache/hadoop/pull/2047#issuecomment-646972696
Thanks @fengnanli for your continued works. LGTM, I would like to give +1 from my side. @goiri I just test this improvement in my test environment but not production cluster. it works fine for me. Another suggestion, I still think we should consider this as common improvement not only for Router, since it is also effective for KMS and other modules who uses ZK to store DTs. So is it proper to move `ZKDelegationTokenSecretManagerImpl` class to common sub project? Of course this is not blocked point. cc @goiri @fengnanli @Cosss7 any suggestions? Thanks @fengnanli again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
