Hexiaoqiao commented on pull request #2080: URL: https://github.com/apache/hadoop/pull/2080#issuecomment-648685825
Thanks @sunchao involve me here. In my internal version I try to turn off `getDatanodeReport` at Router side and not turn on webhdfs feature, The `getDatanodeReport` is very expensive for large cluster from my experience. For this PR, it is almost LGTM from my side, Please check the checkstyle jenkins report: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/5/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt. IMO it is better to add unit test to verify at Router for this improvement. FYI. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
