[
https://issues.apache.org/jira/browse/HADOOP-17079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146102#comment-17146102
]
Hadoop QA commented on HADOOP-17079:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 15 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 18m
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 6m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
26m 0s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
45s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
54s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 11m
33s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 18m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 18m
58s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
3m 5s{color} | {color:orange} root: The patch generated 10 new + 898 unchanged
- 8 fixed = 908 total (was 906) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 6m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
16m 25s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
32s{color} | {color:red} hadoop-common-project/hadoop-common generated 14 new +
0 unchanged - 0 fixed = 14 total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 9m 40s{color}
| {color:red} hadoop-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}128m 54s{color}
| {color:red} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m
9s{color} | {color:green} hadoop-hdfs-httpfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
45s{color} | {color:green} hadoop-hdfs-rbf in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 22m 13s{color}
| {color:red} hadoop-yarn-server-nodemanager in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 94m 51s{color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m
24s{color} | {color:green} hadoop-mapreduce-client-hs in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
59s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}436m 27s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.conf; locked 81% of time
Unsynchronized access at LdapGroupsMapping.java:81% of time Unsynchronized
access at LdapGroupsMapping.java:[line 672] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.groupHierarchyLevels; locked 66%
of time Unsynchronized access at LdapGroupsMapping.java:66% of time
Unsynchronized access at LdapGroupsMapping.java:[line 716] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.groupNameAttr; locked 50% of time
Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized
access at LdapGroupsMapping.java:[line 560] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.ldapCtxFactoryClassName; locked
66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time
Unsynchronized access at LdapGroupsMapping.java:[line 653] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.ldapUrls; locked 50% of time
Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized
access at LdapGroupsMapping.java:[line 830] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.memberOfAttr; locked 60% of time
Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized
access at LdapGroupsMapping.java:[line 530] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.numAttempts; locked 60% of time
Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized
access at LdapGroupsMapping.java:[line 713] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.numAttemptsBeforeFailover; locked
66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time
Unsynchronized access at LdapGroupsMapping.java:[line 724] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.posixGidAttr; locked 50% of time
Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized
access at LdapGroupsMapping.java:[line 426] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.posixUidAttr; locked 60% of time
Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized
access at LdapGroupsMapping.java:[line 427] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.useOneQuery; locked 66% of time
Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized
access at LdapGroupsMapping.java:[line 523] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.useSsl; locked 66% of time
Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized
access at LdapGroupsMapping.java:[line 658] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.userSearchFilter; locked 66% of
time Unsynchronized access at LdapGroupsMapping.java:66% of time
Unsynchronized access at LdapGroupsMapping.java:[line 512] |
| | Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.userbaseDN; locked 66% of time
Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized
access at LdapGroupsMapping.java:[line 512] |
| Failed junit tests | hadoop.security.TestGroupsCaching |
| | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier |
| | hadoop.hdfs.server.balancer.TestBalancer |
| | hadoop.hdfs.TestReconstructStripedFile |
| | hadoop.hdfs.TestMultipleNNPortQOP |
| | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
| | hadoop.hdfs.server.namenode.ha.TestBootstrapStandby |
| | hadoop.hdfs.TestDFSInputStream |
| | hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate |
| | hadoop.hdfs.server.datanode.TestDataNodeUUID |
| | hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy |
| | hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
| |
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption |
| |
hadoop.yarn.server.resourcemanager.placement.TestUserGroupMappingPlacementRule |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://builds.apache.org/job/PreCommit-HADOOP-Build/17005/artifact/out/Dockerfile
|
| JIRA Issue | HADOOP-17079 |
| GITHUB PR | https://github.com/apache/hadoop/pull/2085 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 1a184f9dfac9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 6a8fd73b273 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/17005/artifact/out/diff-checkstyle-root.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HADOOP-Build/17005/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
|
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/17005/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/17005/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/17005/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/17005/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/17005/testReport/ |
| Max. process+thread count | 2838 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs
hadoop-hdfs-project/hadoop-hdfs-rbf
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U:
. |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/17005/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Optimize UGI#getGroups by adding UGI#getGroupsSet
> -------------------------------------------------
>
> Key: HADOOP-17079
> URL: https://issues.apache.org/jira/browse/HADOOP-17079
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Major
> Attachments: HADOOP-17079.002.patch, HADOOP-17079.003.patch
>
>
> UGI#getGroups has been optimized with HADOOP-13442 by avoiding the
> List->Set->List conversion. However the returned list is not optimized to
> contains lookup, especially the user's group membership list is huge
> (thousands+) . This ticket is opened to add a UGI#getGroupsSet and use
> Set#contains() instead of List#contains() to speed up large group look up
> while minimize List->Set conversions in Groups#getGroups() call.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
