kiwik commented on a change in pull request #2103:
URL: https://github.com/apache/hadoop/pull/2103#discussion_r446590723
##########
File path: dev-support/docker/Dockerfile_aarch64
##########
@@ -74,47 +79,24 @@ RUN apt-get -q update \
python-setuptools \
python-wheel \
rsync \
+ shellcheck \
software-properties-common \
- snappy \
sudo \
valgrind \
zlib1g-dev \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
-
-#######
-# OpenJDK 8
-#######
-# hadolint ignore=DL3008
-RUN apt-get -q update \
- && apt-get -q install -y --no-install-recommends openjdk-8-jdk
libbcprov-java \
- && apt-get clean \
- && rm -rf /var/lib/apt/lists/*
-
-
######
-# Install cmake 3.1.0 (3.5.1 ships with Xenial)
-# There is no cmake binary available for aarch64. Build from source.
+# Set env vars required to build Hadoop
######
-# hadolint ignore=DL3003
-RUN mkdir -p /opt/cmake/src \
- && curl -L -s -S \
- https://cmake.org/files/v3.1/cmake-3.1.0-1-src.tar.bz2 \
- -o /opt/cmake/cmake-src.tar.bz2 \
- && tar xvjf /opt/cmake/cmake-src.tar.bz2 -C /opt/cmake/src \
- && cd /opt/cmake/src \
- && tar xvjf cmake-3.1.0.tar.bz2 \
- && cd cmake-3.1.0 && patch -p0 -i ../cmake-3.1.0-1.patch && mkdir .build
&& cd .build \
- && ../bootstrap --parallel=2 \
- && make -j2 && ./bin/cpack \
- && tar xzf cmake-3.1.0-Linux-aarch64.tar.gz --strip-components 1 -C
/opt/cmake \
- && cd /opt/cmake && rm -rf /opt/cmake/src
-ENV CMAKE_HOME /opt/cmake
-ENV PATH "${PATH}:/opt/cmake/bin"
+ENV MAVEN_HOME /usr
+# JAVA_HOME must be set in Maven >= 3.5.0 (MNG-6003)
+ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-arm64
Review comment:
Nice, JAVA_HOME point to java 8.
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
