[ 
https://issues.apache.org/jira/browse/HADOOP-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148716#comment-17148716
 ] 

Ahmed Hussein commented on HADOOP-17099:
----------------------------------------

Looking at the qbt reports, the failed unit tests seem to be flaky for quite 
sometime.
I added a rule in the 
{{hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xmll}} to fail 
whenever a patch introduces a Guava Predicate class.


{code:xml}
        <module name="IllegalImport">
            <property name="illegalClasses"
              value="com.google.common.base.Predicate"/>
        </module>
{code}


> Replace Guava Predicate with Java8+ Predicate
> ---------------------------------------------
>
>                 Key: HADOOP-17099
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17099
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Minor
>         Attachments: HADOOP-17099.001.patch, HADOOP-17099.002.patch
>
>
> {{com.google.common.base.Predicate}} can be replaced with 
> {{java.util.function.Predicate}}. 
> The change involving 9 occurrences is straightforward:
> {code:java}
> Targets
>     Occurrences of 'com.google.common.base.Predicate' in project with mask 
> '*.java'
> Found Occurrences  (9 usages found)
>     org.apache.hadoop.hdfs.server.blockmanagement  (1 usage found)
>         CombinedHostFileManager.java  (1 usage found)
>             43 import com.google.common.base.Predicate;
>     org.apache.hadoop.hdfs.server.namenode  (1 usage found)
>         NameNodeResourceChecker.java  (1 usage found)
>             38 import com.google.common.base.Predicate;
>     org.apache.hadoop.hdfs.server.namenode.snapshot  (1 usage found)
>         Snapshot.java  (1 usage found)
>             41 import com.google.common.base.Predicate;
>     org.apache.hadoop.metrics2.impl  (2 usages found)
>         MetricsRecords.java  (1 usage found)
>             21 import com.google.common.base.Predicate;
>         TestMetricsSystemImpl.java  (1 usage found)
>             41 import com.google.common.base.Predicate;
>     org.apache.hadoop.yarn.logaggregation  (1 usage found)
>         AggregatedLogFormat.java  (1 usage found)
>             77 import com.google.common.base.Predicate;
>     org.apache.hadoop.yarn.logaggregation.filecontroller  (1 usage found)
>         LogAggregationFileController.java  (1 usage found)
>             22 import com.google.common.base.Predicate;
>     org.apache.hadoop.yarn.logaggregation.filecontroller.ifile  (1 usage 
> found)
>         LogAggregationIndexedFileController.java  (1 usage found)
>             22 import com.google.common.base.Predicate;
>     org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation 
>  (1 usage found)
>         AppLogAggregatorImpl.java  (1 usage found)
>             75 import com.google.common.base.Predicate;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to