virajith commented on a change in pull request #2121:
URL: https://github.com/apache/hadoop/pull/2121#discussion_r450505511
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestViewFileSystemOverloadSchemeWithDFSAdmin.java
##########
@@ -215,7 +214,7 @@ public void testSafeModeWithWrongFS() throws Exception {
*/
@Test
public void testSafeModeShouldFailOnLocalTargetFS() throws Exception {
- addMountLinks(defaultFSURI.getAuthority(), new String[] {LOCAL_FOLDER },
+ addMountLinks(defaultFSURI.getHost(), new String[] {LOCAL_FOLDER },
Review comment:
nit: remove space after `LOCAL_FOLDER`
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystemOverloadScheme.java
##########
@@ -85,9 +87,14 @@
* Op3: Create file s3a://bucketA/salesDB/dbfile will go to
* s3a://bucketA/salesDB/dbfile
*
- * Note: In ViewFileSystemOverloadScheme, by default the mount links will be
+ * Note:
+ * (1) In ViewFileSystemOverloadScheme, by default the mount links will be
* represented as non-symlinks. If you want to change this behavior, please see
* {@link ViewFileSystem#listStatus(Path)}
+ * (2) In ViewFileSystemOverloadScheme, the initialized uri's hostname only
will
Review comment:
nit: "the initialized uri's hostname only.." -> "only the initialized
uri's hostname.."
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/ViewFsOverloadScheme.md
##########
@@ -28,7 +28,11 @@ View File System Overload Scheme
### Details
-The View File System Overload Scheme is an extension to the View File System.
This will allow users to continue to use their existing fs.defaultFS configured
scheme or any new scheme name instead of using scheme `viewfs`. Mount link
configurations key, value formats are same as in [ViewFS Guide](./ViewFs.html).
If a user wants to continue use the same fs.defaultFS and wants to have more
mount points, then mount link configurations should have the current
fs.defaultFS authority name as mount table name. Example if fs.defaultFS is
`hdfs://mycluster`, then the mount link configuration key name should be like
in the following format
`fs.viewfs.mounttable.*mycluster*.link.<mountLinkPath>`. We will discuss more
example configurations in following sections.
+The View File System Overload Scheme is an extension to the View File System.
This will allow users to continue to use their existing fs.defaultFS configured
scheme or any new scheme name instead of using scheme `viewfs`.
+Mount link configurations key, value formats are same as in [ViewFS
Guide](./ViewFs.html).
+If a user wants to continue use the same fs.defaultFS and wants to have more
mount points, then mount link configurations should have the
ViewFileSystemOverloadScheme initialized uri's hostname as the mount table name.
+Example if fs.defaultFS is `hdfs://mycluster`, then the mount link
configuration key name should be like in the following format
`fs.viewfs.mounttable.*mycluster*.link.<mountLinkPath>`.
+Even if the initialized fs uri has hostname:port, it will simply ignore the
port number and considers only hostname as mount table name. We will discuss
more example configurations in following sections.
Review comment:
nit: "considers only hostname.." -> "only consider the hostname.."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
