[
https://issues.apache.org/jira/browse/HADOOP-17101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154681#comment-17154681
]
Ahmed Hussein commented on HADOOP-17101:
----------------------------------------
I had a look at the unit tests. My intuition is that having a flaky test
{{TestNameNodeRetryCacheMetrics}} in the module could have some effect on the
success of consecutive test cases.
|TestBlockTokenWithDFSStriped|Filed Jira HDFS-15459|Flaky|
|TestExternalStoragePolicySatisfier|filed HDFS-15456|Flaky|
|TestFileChecksum|for HADOOP-17101, filed HDFS-15461|Flaky|
|TestFileCreation|filed HDFS-15460|Flaky|
|TestFsDatasetImpl|filed HDFS-15457|Flaky|
|TestGetFileChecksum|for HADOOP-17101, Filed HDFS-1546. an old jira exist
HDFS-4723|Flaky|
|TestNameNodeRetryCacheMetrics|filed a jira HDFS-1548|Flaky|
|TestPipelineFailover| |Flaky|
|TestSafeModeWithStripedFileWithRandomECPolicy| |Flaky|
|TestUnderReplicatedBlocks| |Flaky|
|TestBPOfferService| |Flaky|
|TestGroupsCaching| |Flaky|
|TestJournalNodeSync| |Flaky|
|TestUnderReplicatedBlocks| |Flaky|
|TestWebHDFS| |Flaky|
* I added a package {{noguava}} as a place holder for hadoop implementation
for commonly-used code to replace guava packages. In this jira, I needed to
replace {{MultipleMaps}}. I only implemented what is needed for that jira. Then
I will reiterate on the implementation in HADOOP-17108 . My plan is change
HADOOP-17108 into a task, and start adding sub-tasks for needed classes on the
go.
* I added a checkstyle rule to prevent re-introducing import of guava classes
* Based on feedback I got in other Jiras that it is preferred to fix the order
of the import packages, I sorted the imports.
[~jeagles], can you please take a look at the patch?
> Replace Guava Function with Java8+ Function
> -------------------------------------------
>
> Key: HADOOP-17101
> URL: https://issues.apache.org/jira/browse/HADOOP-17101
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Attachments: HADOOP-17101.001.patch, HADOOP-17101.002.patch,
> HADOOP-17101.003.patch, HADOOP-17101.004.patch
>
>
> {code:java}
> Targets
> Occurrences of 'com.google.common.base.Function'
> Found Occurrences (7 usages found)
> hadoop-hdfs-project/hadoop-hdfs/dev-support/jdiff (1 usage found)
> Apache_Hadoop_HDFS_2.6.0.xml (1 usage found)
> 13603 <field name="GET_START_TXID"
> type="com.google.common.base.Function"
> org.apache.hadoop.hdfs.server.blockmanagement (1 usage found)
> HostSet.java (1 usage found)
> 20 import com.google.common.base.Function;
> org.apache.hadoop.hdfs.server.datanode.checker (1 usage found)
> AbstractFuture.java (1 usage found)
> 58 * (ListenableFuture, com.google.common.base.Function)
> Futures.transform}
> org.apache.hadoop.hdfs.server.namenode.ha (1 usage found)
> HATestUtil.java (1 usage found)
> 40 import com.google.common.base.Function;
> org.apache.hadoop.hdfs.server.protocol (1 usage found)
> RemoteEditLog.java (1 usage found)
> 20 import com.google.common.base.Function;
> org.apache.hadoop.mapreduce.lib.input (1 usage found)
> TestFileInputFormat.java (1 usage found)
> 58 import com.google.common.base.Function;
> org.apache.hadoop.yarn.api.protocolrecords.impl.pb (1 usage found)
> GetApplicationsRequestPBImpl.java (1 usage found)
> 38 import com.google.common.base.Function;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
