steveloughran commented on a change in pull request #2134: URL: https://github.com/apache/hadoop/pull/2134#discussion_r453902358
########## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/noguava/Preconditions.java ########## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.util.noguava; + +import java.util.Collection; +import java.util.Objects; +import javax.annotation.Nullable; + +public final class Preconditions { + private static final String VALIDATE_STATE_EX_MESSAGE = + "The validated state is false"; + private static final String VALIDATE_IS_NOT_NULL_EX_MESSAGE = + "The validated object is null"; + private static final String VALIDATE_RANGE_INDEX_ARRAY_EX_MESSAGE = + "The validated array size: %d, index is out of range: %d"; + private static final String VALIDATE_INDEX_ARRAY_EX_MESSAGE = + "The validated array index is invalid: %d"; + private static final String VALIDATE_SIZE_ARRAY_EX_MESSAGE = + "The validated array size is invalid: %d"; + private static final String VALIDATE_IS_TRUE_EX_MESSAGE = + "The validated expression is false"; + + private Preconditions() { + super(); + } + + public static void checkIsTrue(final boolean expression, final String message, Review comment: its explicitly an argument here, hence the IllegalArgumentException. We will also need checkState, which throw ome illegal state exception too. We need both and so the check method names should be distinct ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
