[
https://issues.apache.org/jira/browse/HADOOP-17127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157567#comment-17157567
]
Hudson commented on HADOOP-17127:
---------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18435 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/18435/])
HADOOP-17127. Use RpcMetrics.TIMEUNIT to initialize rpc queueTime and (xkrogen:
rev 317fe4584a51cfe553e4098d48170cd2898b9732)
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcScheduler.java
* (edit)
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
> Use RpcMetrics.TIMEUNIT to initialize rpc queueTime and processingTime
> ----------------------------------------------------------------------
>
> Key: HADOOP-17127
> URL: https://issues.apache.org/jira/browse/HADOOP-17127
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: Jim Brennan
> Assignee: Jim Brennan
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: HADOOP-17127.001.patch, HADOOP-17127.002.patch
>
>
> While making an internal change to use {{TimeUnit.MICROSECONDS}} instead of
> {{TimeUnit.MILLISECONDS}} for rpc details, we found that we also had to
> modify this code in DecayRpcScheduler.addResponseTime() to initialize
> {{queueTime}} and {{processingTime}} with the correct units.
> {noformat}
> long queueTime = details.get(Timing.QUEUE, TimeUnit.MILLISECONDS);
> long processingTime = details.get(Timing.PROCESSING,
> TimeUnit.MILLISECONDS);
> {noformat}
> If we change these to use {{RpcMetrics.TIMEUNIT}} it is simpler.
> We also found one test case in TestRPC that was assuming the units were
> milliseconds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
