iwasakims commented on pull request #2146:
URL: https://github.com/apache/hadoop/pull/2146#issuecomment-659347835


   It worked on my local while a bit more warnings are generated by spotbugs 
4.0.6.
   
   before
   ```
   $ mvn clean install findbugs:findbugs -DskipTests -DskipShade
   $ find . -name findbugsXml.xml | xargs -n 1 
/opt/spotbugs-4.0.6/bin/convertXmlToText 
   H C UMAC: Uncallable method 
org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage$1.getInstance()
 defined in anonymous class  At 
TestTimelineReaderWebServicesHBaseStorage.java:[line 87]
   M D DLS: Dead store to entities in 
org.apache.hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown.checkQuery(HBaseTimelineReaderImpl)
  At TestTimelineReaderHBaseDown.java:[line 190]
   M V EI: org.apache.hadoop.fs.cosn.CosNInputStream$ReadBuffer.getBuffer() may 
expose internal representation by returning CosNInputStream$ReadBuffer.buffer  
At CosNInputStream.java:[line 87]
   ```
   
   after:
   ```
   $ mvn clean install findbugs:findbugs -DskipTests -DskipShade
   $ find . -name findbugsXml.xml | xargs -n 1 
/opt/spotbugs-4.0.6/bin/convertXmlToText 
   M D DLS: Dead store to $L5 in 
org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String)  At 
Server.java:[line 3729]
   M D DLS: Dead store to $L5 in 
org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String)  At 
Server.java:[line 3717]
   H D NP: Method 
org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker$ResultHandler.onSuccess(Object)
 overrides the nullness annotation of parameter $L1 in an incompatible way  At 
DatasetVolumeChecker.java:[line 322]
   H D NP: Method 
org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker$ResultHandler.onSuccess(VolumeCheckResult)
 overrides the nullness annotation of parameter result in an incompatible way  
At DatasetVolumeChecker.java:[lines 358-376]
   M D NP: Method 
org.apache.hadoop.hdfs.server.datanode.checker.ThrottledAsyncChecker$2.onSuccess(Object)
 overrides the nullness annotation of parameter result in an incompatible way  
At ThrottledAsyncChecker.java:[lines 170-175]
   M D DLS: Dead store to $L8 in 
org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.incrOpCount(FSEditLogOpCodes,
 EnumMap, Step, StartupProgress$Counter)  At FSEditLogLoader.java:[line 1241]
   M D NP: result must be non-null but is marked as nullable  At 
LocatedFileStatusFetcher.java:[lines 380-397]
   M D NP: result must be non-null but is marked as nullable  At 
LocatedFileStatusFetcher.java:[lines 291-309]
   M D DLS: Dead store to $L6 in 
org.apache.hadoop.yarn.sls.SLSRunner.increaseQueueAppNum(String)  At 
SLSRunner.java:[line 816]
   H C UMAC: Uncallable method 
org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage$1.getInstance()
 defined in anonymous class  At 
TestTimelineReaderWebServicesHBaseStorage.java:[line 87]
   M D DLS: Dead store to entities in 
org.apache.hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown.checkQuery(HBaseTimelineReaderImpl)
  At TestTimelineReaderHBaseDown.java:[line 190]
   M V EI: org.apache.hadoop.fs.cosn.CosNInputStream$ReadBuffer.getBuffer() may 
expose internal representation by returning CosNInputStream$ReadBuffer.buffer  
At CosNInputStream.java:[line 87]
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to