ayushtkn commented on a change in pull request #2166:
URL: https://github.com/apache/hadoop/pull/2166#discussion_r459696176
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
##########
@@ -2004,6 +2005,16 @@ public void renameSnapshot(String snapshotRoot, String
snapshotOldName,
return status;
}
+ @Override // Client Protocol
+ public SnapshotStatus[] getSnapshotListing(String path)
Review comment:
Keep the argument name consistent, In ClientProtocol & Router its
snapshotRoot, better keep same everywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
