[ 
https://issues.apache.org/jira/browse/HADOOP-16281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167211#comment-17167211
 ] 

Steve Loughran commented on HADOOP-16281:
-----------------------------------------

[~daryn] -sorry, only just seen this comment. 

The PR you are referring to is HADOOP-11452, which does say "make the 
rename(src, dest, ops) which has been around for ages but tagged protected 
something public and stable"

Because classic rename() isn't great to use -as well as inconsistent semantics 
of rename(source-dir, empty-dir), it's failure mode on major issues like source 
file missing is "return false". Which is useless when trying to debug why hive 
job commits failed.

We do need a better rename. Making the rename/3 one public does that. I'm now 
thinking we could really do with some builder one which returned a future to 
some result, where the result could include stats on cost/duration of the 
rename (HADOOP-16830).

* No change in semantics of rename/3, just tests for what it does and making it 
public
* The only change which has gone in to HDFS should have been standardising the 
error messages. If you think that will break things, happy to leave that bit out


> ABFS: Rename operation, GetFileStatus before rename operation and  throw 
> exception on the driver side
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-16281
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16281
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.2.0
>            Reporter: Da Zhou
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: abfsactive
>
> ABFS should add the rename with options:
>  [https://github.com/apache/hadoop/pull/743]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to