aajisaka commented on a change in pull request #253:
URL: https://github.com/apache/hadoop/pull/253#discussion_r463415415



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
##########
@@ -1816,7 +1816,10 @@ private boolean delBlockFromDisk(ReplicaInfo info) {
   @Override // FsDatasetSpi
   public void checkBlock(ExtendedBlock b, long minLength, ReplicaState state)
       throws ReplicaNotFoundException, UnexpectedReplicaStateException,
-      FileNotFoundException, EOFException, IOException {
+      FileNotFoundException, EOFException, IOException, NullPointerException {
+    if(b == null){
+      throw new NullPointerException("Input Block is null!");
+    }

Review comment:
       I checked the call hierarchy of the method and `b` is always non-null.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to