mukul1987 commented on a change in pull request #2175:
URL: https://github.com/apache/hadoop/pull/2175#discussion_r463786951
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
##########
@@ -498,9 +498,14 @@
public static final int
DFS_NAMENODE_SNAPSHOT_DIFF_LISTING_LIMIT_DEFAULT = 1000;
- public static final String DFS_NAMENODE_SNAPSHOT_MAX_LIMIT =
- "dfs.namenode.snapshot.max.limit";
+ public static final String
+ DFS_NAMENODE_SNAPSHOT_MAX_LIMIT = "dfs.namenode.snapshot.max.limit";
Review comment:
Lets change DFS_NAMENODE_SNAPSHOT_MAX_LIMIT to
DFS_NAMENODE_SNAPSHOT_MAX_DIRECTORY_LIMIT. and lets use the same reference of
the variable internally;
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java
##########
@@ -117,23 +119,37 @@ public SnapshotManager(final Configuration conf, final
FSDirectory fsdir) {
DFSConfigKeys.DFS_NAMENODE_SNAPSHOT_DIFF_ALLOW_SNAP_ROOT_DESCENDANT,
DFSConfigKeys.
DFS_NAMENODE_SNAPSHOT_DIFF_ALLOW_SNAP_ROOT_DESCENDANT_DEFAULT);
+ this.maxSnapshotLimitPerDirectory = conf.getInt(
+ DFSConfigKeys.
+ DFS_NAMENODE_SNAPSHOT_MAX_LIMIT,
+ DFSConfigKeys.
+ DFS_NAMENODE_SNAPSHOT_MAX_LIMIT_DEFAULT);
this.maxSnapshotLimit = conf.getInt(
- DFSConfigKeys.DFS_NAMENODE_SNAPSHOT_MAX_LIMIT,
- DFSConfigKeys.DFS_NAMENODE_SNAPSHOT_MAX_LIMIT_DEFAULT);
+ DFSConfigKeys.DFS_NAMENODE_SNAPSHOT_GLOBAL_LIMIT,
+ DFSConfigKeys.DFS_NAMENODE_SNAPSHOT_GLOBAL_LIMIT_DEFAULT);
LOG.info("Loaded config captureOpenFiles: " + captureOpenFiles
+ ", skipCaptureAccessTimeOnlyChange: "
+ skipCaptureAccessTimeOnlyChange
+ ", snapshotDiffAllowSnapRootDescendant: "
+ snapshotDiffAllowSnapRootDescendant
+ ", maxSnapshotLimit: "
- + maxSnapshotLimit);
+ + maxSnapshotLimit
Review comment:
maxSnapshotLimit -> maxSnapshotDirectroyLimit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
