mukund-thakur commented on a change in pull request #2133:
URL: https://github.com/apache/hadoop/pull/2133#discussion_r464386889
##########
File path:
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java
##########
@@ -160,10 +160,10 @@ public void testPreserveStatus() throws IOException {
context.setTargetPathExists(false);
CopyListing listing = new GlobbedCopyListing(conf, CREDENTIALS);
- Path listingFile = new Path("/tmp1/" + String.valueOf(rand.nextLong()));
+ Path listingFile = new Path("/tmp1/" + rand.nextLong());
listing.buildListing(listingFile, context);
- conf.set(DistCpConstants.CONF_LABEL_TARGET_WORK_PATH, targetBase);
+ conf.set(DistCpConstants.CONF_LABEL_TARGET_FINAL_PATH, targetBase);
Review comment:
Thanks got it. Code was wrong as well as the testcase was wrong. Thanks
for fixing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
