msamirkhan commented on a change in pull request #2198:
URL: https://github.com/apache/hadoop/pull/2198#discussion_r466814342
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/UsersManager.java
##########
@@ -91,8 +90,12 @@
new HashMap<String, Set<ApplicationId>>();
// Pre-computed list of user-limits.
- Map<String, Map<SchedulingMode, Resource>> preComputedActiveUserLimit = new
ConcurrentHashMap<>();
- Map<String, Map<SchedulingMode, Resource>> preComputedAllUserLimit = new
ConcurrentHashMap<>();
+ @VisibleForTesting
+ Map<String, Map<SchedulingMode, Resource>> preComputedActiveUserLimit =
+ new HashMap<>();
+ @VisibleForTesting
+ Map<String, Map<SchedulingMode, Resource>> preComputedAllUserLimit =
+ new HashMap<>();
Review comment:
Both these maps were only being called under locks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
