mukund-thakur commented on a change in pull request #2149:
URL: https://github.com/apache/hadoop/pull/2149#discussion_r468621232
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java
##########
@@ -295,12 +350,14 @@ protected void renameFileToDest() throws IOException {
callbacks.deleteObjectAtPath(sourcePath, sourceKey, true, null);
// and update the tracker
renameTracker.sourceObjectsDeleted(Lists.newArrayList(sourcePath));
+ return copyDestinationPath;
}
/**
* Execute a full recursive rename.
- * The source is a file: rename it to the destination.
- * @throws IOException failure
+ * There is a special handling of directly markers here -only leaf markers
+ * are copied. This reduces incompatibility "regions" across versions.
+Are * @throws IOException failure
Review comment:
nit: typo in javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
