steveloughran commented on pull request #2149:
URL: https://github.com/apache/hadoop/pull/2149#issuecomment-673382450
> The condition and message doesn't seem consistent. Please review.
it is. I'm adding a comment. I'm going to put in a unit test to verify the
condition. Key point: if needEmptyDirFlag is false: we don't care, if it is
true then the probe must contain a list, so
```
!needEmptyDirectoryFlag ||
(needEmptyDirectoryFlag && probes.contains(StatusProbeEnum.List))
```
And obviously, the second test of the flag state is superflouous, which is
why IDEs and things complain about it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
