umamaheswararao commented on a change in pull request #2229:
URL: https://github.com/apache/hadoop/pull/2229#discussion_r471048629
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
##########
@@ -727,11 +727,6 @@ protected void initialize(Configuration conf) throws
IOException {
intervals);
}
}
- // Currently NN uses FileSystem.get to initialize DFS in startTrashEmptier.
- // If fs.hdfs.impl was overridden by core-site.xml, we may get other
- // filesystem. To make sure we get DFS, we are setting fs.hdfs.impl to DFS.
- // HDFS-15450
- conf.set(FS_HDFS_IMPL_KEY, DistributedFileSystem.class.getName());
Review comment:
Actually in ViewFileSystemOverloadScheme, we started auto assigning
fallback link. So, we will have at least one link so, NN side init will succeed
with that behavior. The tests added in HDFS-15450 passes now even with removing
above line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
