YaYun-Wang commented on a change in pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#discussion_r476144965
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStoragePolicySuite.java
##########
@@ -63,6 +63,12 @@ public static BlockStoragePolicySuite createDefaultSuite(
new StorageType[]{StorageType.DISK},
new StorageType[]{StorageType.DISK},
true); // Cannot be changed on regular files, but inherited.
+ final byte allNVDIMMId = HdfsConstants.StoragePolicy.ALL_NVDIMM.value();
Review comment:
> The overall change looks good to me, thanks! I will finish the review
of testing in 1/2 days and provide more input.
>
> I also will check which `isTransient()` will need to be replaced with
`isRAM()`. It seems case by case for all usages. One simple question is for
this NVDIMM storage type, we save the checksum file right?
The calculation of checksum in hadoop is the responsibility of clients and
datanodes, each storage media including NVDIMM participates in the checksum of
data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
